"write" permission not allowed in list of values for "allow"
See original GitHub issueWhile trying to configure my module scripts, I stumbled upon a squiqqly orange warning underline in Visual Studio Code (using https://github.com/jurassiscripts/vscode-velociraptor) after adding "write"
to the list of permissions under the key "allow"
in my scripts.json
:
![Bildschirmfoto 2021-03-27 um 10 42 43](https://user-images.githubusercontent.com/20396367/112716864-2be6c400-8ee9-11eb-94cc-f30a34080280.png)
Examining this further, it seems like the value "write"
is not in the list of allowed values, even though it should be:
![Bildschirmfoto 2021-03-27 um 10 43 14](https://user-images.githubusercontent.com/20396367/112716877-3dc86700-8ee9-11eb-8dfb-30d0698ac409.png)
According to the readme of velociraptor, the section Permissions states that Deno permissions can be specified using the allow
key, of which all but "write"
can be specified without a warning.
I created this issue here because the vscode extension (at least at the moment) is only a “wrapper” around code in this repository and any fix there would actually be a fix here.
My suggestion would be to add write?: string | boolean;
here to the AllowFlags
interface in scripts_config.ts, for which I will add a PR shortly.
Issue Analytics
- State:
- Created 2 years ago
- Comments:6 (3 by maintainers)
No worries, yours is a better solution. Thanks for updating, love the project.
You’re right! Actually some time ago I added a data provider that fetches the last vr version automatically at build time but I forgot to use it in this section. I fixed this while I was working on the dark theme, you should see the right version now! Thank you so much for the PR anyway 🙂