Double base url appended

Using /v1/api via:

window.axios.defaults.baseURL = '/v1/api/'

On error results in ‘/v1/api/v1/api’ call

[avindra]

@riksnelders , others: I noticed in the code posted in the OP has a relative URL, not an absolute URL.

Axios is making a lot of assumptions in their code that the URL MUST be absolute. An easy fix may be to set it to location.origin + '/v1/your/api/base/here'.

After making this change in our app, I noticed this bug went away.

---

Aside, this is actually a core axios expectation.

This is actually spelled out in the documentation, but its extremely easy to overlook (its in the comment above the baseUrl config in the code:

https://github.com/axios/axios#request-config

I think if enough heads work on the problem, they can clean it up and have baseUrl ALSO support relative paths, as that expectation works cleanly with just core axios. The sloppy handling of config values manifests an issue when trying to add the retry functionality.

[Spyna]

Facing the same issue, and is not related to retry-axios but to axios. If you look at dispatchRequest.js in the axios source code you’ll see near line 25.

  // Support baseURL config
  if (config.baseURL && !isAbsoluteURL(config.url)) {
    config.url = combineURLs(config.baseURL, config.url);
  }

If you don’t use an absolute URL as baseURL, the config.url will be always combined with the baseURL.

This means that… if you do window.axios.defaults.baseURL = '/v1/api/', the first time you execute a request, such as axios.get('/user') the actual url will be [config.baseURL] + [config.url] = '/v1/api/ + user' = '/v1/api/user'.

When that request is retried the code of dispatchRequest.js will be repeated, and now the value of url is already “prepended” with the baseURL. So the config.url will end up with [baseURL] + [url] = '/v1/api/ + /vi/api/user' = '/v1/api/v1/api/user'.

Solutions

• Use an absolute URL as the baseURL
• Use a request interceptor to purge the config.URL if the request is being retried