Usability Request: Remove "Ctrl-C Ctrl-C" from COMMIT_EDITMSG mode

Proposed Change:

Remove special “Ctrl-c Ctrl-c” keystroke In the commit message editing mode. Instead, the users can use the standard “Ctrl-s Ctrl-w” to save and close the file in the editor. This way “Ctrl-c” is available for copying content.

Rationale

vscode users likely already have a simple way to deal with “save and close a file”, either with the default key bindings or something custom to their setup. Since C-c C-c is really just saving and closing the buffer under the hood, there is no reason to add it.

Users with the default key-bindings will definitely be surprised to find that they cannot copy text in a commit message. It has burned me when I tried to copy reproduction steps from text and then paste it into a terminal to verify a fix.

This will be a muscle memory change for users with a long history with magit, but one that should be pretty quick to get used to.

[matklad]

+1 as Emacs expat, I appreciate that C-c just works, but it gets in a way when I need to copy text. Moreover, most VS Code users are not Emacs users, and for them C-c is just O_o.

I wonder if Ctrl-Enter for commit/Escape to abort would work?

[dandavison]

Just a note: for Mac users there’s no conflict here: copy is Cmd-c and the traditional emacs “execute & dismiss” operation used widely in e.g. magit and org-mode is Ctrl-c Ctrl-c. So for that group of users at least I think it would be a shame/inappropriate to get rid of the Ctrl-c Ctrl-c binding which, as you say, is muscle memory for a magit user.