[Idea] Create Apollo on Dependency Injection level

TL;DR: An InjectionToken for options of the default ApolloClient as an alternative way to initialize Apollo, a replacement for Apollo.create (both will be supported).

An example:

import {NgModule} from '@angular/core';
import {HttpClientModule} from '@angular/common/http';
import {ApolloOptionsToken, ApolloModule} from 'apollo-angular';
import {HttpLink, HttpLinkModule} from 'apollo-angular-link-http';
import {InMemoryCache} from 'apollo-cache-inmemory';

@NgModule({
  imports: [HttpClientModule, ApolloModule, HttpLinkModule],
  providers: [
    {
      provide: ApolloOptionsToken,
      useFactory: httpLink => {
        return {
          link: httpLink.create({uri: 'https://api.example.com/graphql'}),
          cache: new InMemoryCache(),
        };
      },
      deps: [HttpLink],
    },
  ],
})
class AppModule {}

Details

Why?

Why we didn’t do it in a first place? For one reason, it’s way more complex and not all of Angular Developers are familiar with how Dependency Injection’s work and how to provide a service other than just put a class in an Array (NgModules.providers). Apollo.create is way simpler and easier to get started with Apollo for everyone and I think it’s the best approach.

Do you like it? I already prepared a branch with those changes.

[patricknazar]

I am still not sure how to use this module with feature modules. The Client has not been defined yet error comes up for me with lazy-loaded feature modules (via angular router) but fine when under imports.

Edit: Ended up using the method described in https://alligator.io/angular/providers-shared-modules/

[patricknazar]

Here is an example repo for anyone wanting to see how this works.