Karma exits with code 0 when the coverage threshold is below the configuration

Hi,

I added this configuration to my karma.conf.js

            type: 'html',
            dir: 'test/coverage/',
            check: {
                global: {
                    statements: 85,
                    branches: 70,
                    functions: 85,
                    lines: 85
                }
            }

The logs work fine and if the thresholds are not met, I can see error logs in the terminal but karma always exit wit code 0. That affect my CI process that is not able to detect something is wrong.

The documentation says

If the thresholds are not met, karma will return failure.

and I’ve review the code and I’ve seen the plugin is setting the exit code to 1 so I’m not sure if it is a issue in karma-coverage or in karma itself.

I’m using : karma@5.1.1 karma-coverage@2.0.3

[matz3]

Solved with karma v5.2.0 (in combination with karma-coverage v2.0.3)

[jesusbarcenilla]

@matz3 It looks like your PR was already merged in master. I’ve tested it and it works fine. Looking forward for the next karma release. I’ll keep this issue open until then.

Thank you very much.