Is KatharsisProperties.RESOURCE_DEFAULT_DOMAIN really required?

From @chabala on July 13, 2016 22:53

I see in the example code that specifying RESOURCE_DEFAULT_DOMAIN is recommended.

https://github.com/katharsis-project/katharsis-examples/blob/master/jersey-example/src/main/java/io/katharsis/example/jersey/JerseyApplication.java#L23

In fact, while Katharsis will serve resources without having that property set, all the links that are generated will have null in the place where the URI scheme and hostname were expected.

This seems unnecessary to configure, as JAX-RS will inject a UriInfo object that can be used to obtain that information: https://jersey.java.net/documentation/latest/uris-and-links.html

I expect a call to UriInfo.getBaseUri() would net the same information that is being manually supplied.

I could submit a PR for this, but I thought we might discuss it first.

Copied from original issue: katharsis-project/katharsis-rs#40

[chb0github]

Second idea (an probably easier to implement inside katharsis):

public interface ServiceUrlProvider {
    String getUrl();
}

public class ResourceRegistry {
    private final Map<Class, RegistryEntry> resources = new HashMap<>();
    private final ServiceUrlProvider serviceUrlProvider;
    private final Logger logger = LoggerFactory.getLogger(ResourceRegistry.class);

    public ResourceRegistry(ServiceUrlProvider serviceUrlProvider) {
        this.serviceUrlProvider = serviceUrlProvider;
    }

   public String getResourceUrl(Class clazz) {
        return serviceUrlProvider.getUrl() + "/" + getResourceType(clazz);
    }

@Component
public class DefaultServiceUrlProvider implements ServiceUrlProvider {

    @Value("${katharsis.pathPrefix}")
    private String pathPrefix;

    @Resource
    private HttpServletRequest request;

    public String getUrl() {
        String scheme = request.getScheme();
        String host = request.getHeader("host");
        String resourceType = registry.getResourceType(clazz);
        return scheme + "://" + host + pathPrefix;
    }
}

Doing it this way means you can offload the implementation to katharsis-rs and have it inject the implementation.

[chb0github]

Closed by #140