barWidth option broken after commit 18cad42e

Wavesurfer.js version(s):

latest master

Browser and operating system version(s):

electron: 4.0.4 chrome: 69.0

hi! firstly thank you for the great library, i’m having a lot of fun working with it.

i have been keeping up with the latest master and noticed that the waveform has stopped generating with commit 18cad42e (canvasentry refactor)

pre 18cad42e:

post 18cad42e:

my params are:

const params = {
            audioContext: this.audioContext,
            container: '#waveform',
            waveColor: '#04ABED',
            progressColor: 'black',
            cursorColor: '#fff',
            barWidth: 3,
            barGap: 2,
            barRadius: true,
            height: 180,
            barHeight: 1,
            scrollParent: true,
            responsive: true,
            closeAudioContext: true,
            //forceDecode: true,
            plugins: [
                TimelinePlugin.create({
                    container: '#timeline',
                    primaryColor: "#fff",
                    fontFamily: 'Roboto Condensed',
                }),
                MinimapPlugin.create({
                    container: "#minimap",
                    waveColor: '#000',
                    progressColor: 'black',
                    height: 30,
                    showOverview: true,
                    barWidth: 0,
                    barGap: 0,
                    barRadius: false,
                    overviewBorderColor: "azure",
                }), 
            ],
        };

let me know if you need more info!

[sandiz]

hi @thijstriemstra pushed a fix for this in pr #1637, some arguments were missing.

[thijstriemstra]

i can investigate further if you give me some pointers…

@sandiz if you can help figure out what broke during that refactor, much appreciated, I’m focusing on other areas right now. This issue does block the 3.0.0 release though, which sucks.