Load peaks from file post v1.2.8
See original GitHub issueHi !
With v1.2.8, To get peaks and create peaks file from it, I use to use this:
peaks = object.backend.getPeaks(960);
This seems to be broken post v1.2.8 (like v1.4.0).
After quite some testing, I found that the following code produces the same json file than in v1.2.8
peaks = object.backend.getPeaks(960, 0, 959);
Note: I think there should have been something do about this to assure backward compatibility, as I spent hours on it, thinking the problem came from elsewhere.
Well I thought that it was good, but despite the files are now the same as before, it seems that something have also change in the way they are render !
Here is my code: wavesurfer.load(file_url, peaks, preload);
and here is what I got with v1.2.8
And here is the same peaks files, but loaded with v1.4.0 (and v1.3.x)
Why is there such difference ? What is the new way to load peaks ? Could backward compatibility be assured right within wavesurfer-js ?
Thanks for your assistance !
Issue Analytics
- State:
- Created 6 years ago
- Comments:38 (18 by maintainers)
Top GitHub Comments
closing, fixed once pr #1114 is merged. re-open if issue persists after merge.
@X-Raym @taylorvc May you guys test it with the files now. https://codepen.io/entonbiba/pen/PmpXqJ