Restore splitter-merger to play well with setFilters
See original GitHub issueWhen trying to add nodes to a WebAudio graph using the setFilters
method in version 1.1.1, I get the following error:
Uncaught TypeError: Failed to execute ‘connect’ on ‘AudioNode’: No function was found that matched the signature provided.
The error is in reference to this line of the setFilters
method, which was changed in PR#689.
I’m not doing anything fancy - just mixing three separate mono waveforms into stereo, with one of them panned center and the others panned left and right. The relevant code for one of them (called waveLeft
) looks like this:
var centerGain = 0.3;
var pannerLeft = waveLeft.backend.ac.createStereoPanner();
pannerLeft.pan.value = -1;
var gainL = waveLeft.backend.ac.createGain();
gainL.gain.value = 1 - centerGain;
waveLeft.backend.setFilters([pannerLeft, gainL]);
It was still working as of v1.1.0:
http://fiddle.jshell.net/nathansnider/qqtjko16/
but produces the error (and does not add any panner and gain nodes) in v1.1.1:
Issue Analytics
- State:
- Created 7 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Satisfactory modding
Satisfactory can be played in multiplayer, with up to four players ... 2022 · Satisfactory Steam Mods The effects of commands are reset...
Read more >Satisfactory modding
Play alone or with friends, explore an alien planet, create multi-story factories, and enter conveyor belt heaven! Construct Conquer nature by building ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Well, just revert it then, maybe the
setChannel
function should be implemented in user code usingsetFilters
anyway. It’s better to keep the default filters as simple as possible.Yes,
setFilters
is working again in 1.1.2. Thanks, @katspaugh! Looks like we can close this issue, unless you want to keep it open for future work on the splitter-merger.