question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Seek Behavior Changed in 4.2.0

See original GitHub issue

Seeking while playing audio now pauses. In the past, it would keep playing.

Wavesurfer.js version(s):

4.3.0

Code needed to reproduce the issue:

4.1.0 behaviour: https://codepen.io/sundays/pen/XWjZpxG

4.3.0 behaviour: https://codepen.io/sundays/pen/KKgQvwG

Use behaviour needed to reproduce the issue:

  1. Click codepen for 4.1.0
  2. Click play
  3. Click on waveform to seek. It keeps playing.
  4. Go to the codepen for 4.3.0, repeat the steps. The audio pauses when clicking to seek

The question is which is the correct behavior? Should seeking while playing audio cause it to pause? Or should it keep going? #2045 seems to have caused this.

Workaround to restore old behavior is to listen to the 'seek' event, check isPlaying(), and call play() yourself.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
thijstriemstracommented, Jan 5, 2021

So when those lines are brought back, there needs to be a condition to skip them if the backend isn’t WebAudio.

Sounds good. Want to make a pr (since you “screwed up” 😛)?

1reaction
todoroffcommented, Jan 5, 2021

I think MediaElementWebAudio should be extending MediaElement (as it is now), since it’s virtually the same, only feeding it into a webaudio node. Speaking of which, if we revert the changes from from #2045, it seems like those should be ignored by the MediaElementWebAudio backend as well.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Android Gradle Plugin 4.2.x changed behavior for ...
I noticed a behaviour change using the Android Gradle Plugin 4.2.x regarding the ProGuard assumenosideeffects rule.
Read more >
Release Notes - Identity Provider 4 - Confluence
4.2.0 (April 15, 2022) ... Changes to Existing Behavior ... It includes an automatic behavioral change that tracks the endpoint used to deliver...
Read more >
R News - The Comprehensive R Archive Network
CHANGES IN R 4.2.0. SIGNIFICANT USER-VISIBLE CHANGES. The formula method of aggregate() now matches the generic in naming its first argument x (resolving ......
Read more >
Changelog — Supervisor 4.2.5 documentation - Supervisord
The behavior of the config file expansion %(here)s has changed. In previous versions, a bug caused %(here)s to always expand to the directory...
Read more >
Inno Setup 4.2 Revision History
Fix: During installation, it now processes input events while seeking backwards in ... The default behavior is now identical to that of pre-4.2.0...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found