Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Refactor use-search to use a properly-typed fuzzy-search library

See original GitHub issue

Brief

The current useSearch() implementation uses the itemsjs library, which has no proper typings. This leads to useSearch() being littered with any type annotations.

We want to avoid using any if possible. Therefore, we should migrate to a search library with proper typings (e.g. fusejs).

Definition of done

use-search properly migrated to a library with valid typings.
All any are replaced by correct typings.

Tasks

Migrate to a properly typed fuzzy search library
Refactor use-search to use fusejs and add proper typings

Issue Analytics

State:
Created 2 years ago
Comments:7 (6 by maintainers)

Top GitHub Comments

3reactions

mazipancommented, Jul 21, 2021

Since this issue is classified as hard-level. I think it’s better if we introduce an automated testing first for this component before go on the refactoring part.

The hard part is you need to tackle all cases, testing it, make sure it’s not breaking. From my personal experience, testing using a manual way when you’re not the original creator is very risky.

@resir014 @zainfathoni

2reactions

mazipancommented, Jul 20, 2021