Prism being contained in CodeFlask removes plugin abilities
See original GitHub issueI use the Custom Class plugin to namespace the Prism classes, since some of them conflict with my own CSS.
Before 1.0, CodeFlask used the Prism that I provided, meaning everything worked just fine. Now, however, CodeFlask uses its own version of Prism, meaning that I no longer can use the plugin, which breaks styling.
I see no way to interface with CodeFlask’s version of Prism outside of the language functions. (I see Prism is in the global namespace, confusing me even more as to why it’s included with CodeFlask) I would love to see a way to disable CodeFlask’s version of Prism and be able to use my own, similar to how it was before 1.0. I can only see more issues in the future because of Prism being included in CodeFlask instead of CodeFlask depending on it.
This may change depending on the load order, but I have to load Prism before CodeFlask so I can add languages to it (#65 related). I suppose that I could maybe load Prism before CodeFlask, change its name to Prism2
, then set CodeFlask’s Prism
equal to Prism2
, but that seems like a gigantic hack.
Either way, I shouldn’t have to (and by extension shouldn’t have to force my users to) load Prism twice 😢
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (3 by maintainers)
Top GitHub Comments
Maybe I like one sugar and no cream and @kashike likes two and cream. When the coffee comes with a pre-determined amount of cream and sugar, though, we don’t get a choice. Maybe I don’t want the extra calories or might decide I want cream sometimes but not other times. I don’t really get a choice when everything is bundled and injected for me.
It makes everything marginally easier for the developer throwing together a quick project (one
script
element instead of twoscript
s and onelink
), but it makes it much less flexible and adds a lot of frustration for people using it for big projects.Edit: That being said, if we can get rid of inline styles and resolve this issue, I’ll be happy either way ¯\_(ツ)_/¯
And it’s another reason that makes people not want to use your library.
If I go to a coffee shop and order a plain coffee I expect a plain coffee, not a coffee with cream and sugar.