Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

after_catalog_created fires on tab complete

See original GitHub issue

Description

Is this expected behavior? It’s not something that I expected or was intuitive to me.

Context

Looking for discussion around this, does it make sense to fix, document, or is it working as expected?

Steps to Reproduce

apply an after_catalog_created hook to a pipeline
open ipython and create a context object (kedro ipython)
context.cata<TAB>

Expected Result

after_catalog_created hook should fire after the catalog is created, not during tab complete

Your Environment

Include as many relevant details about the environment in which you experienced the bug:

Kedro version used (pip show kedro or kedro -V): 0.17.1 and 0.17.3
Python version used (python -V): 3.8.10
ipython version used: 7.21.0
Operating system and version: Ubuntu

Issue Analytics

State:
Created 2 years ago
Comments:9 (6 by maintainers)

Top GitHub Comments

3reactions

limdautocommented, Jun 13, 2021

The decision to recreate the catalog every time users access context.catalog predates me. I guess it’s to cater to this notebook workflow, i.e. users can play with dataset in a notebook and update catalog.yaml. Then when users go back to the notebook, we expect that catalog to be updated.

As @WaylonWalker mentioned, I think it’s wrong to have catalog changing within the same session. We meant to create an interactive session for notebook to do autoreload of library components better but never got round to.

1reaction

mzjp2commented, Jun 2, 2021

Is this possible related: https://github.com/ipython/ipython/issues/9094?