[KED-1169] Library code should be framework decision agnostic
See original GitHub issueDescription
This line in library code makes assumptions about the user code (i.e. that the directory src
exists). This used to be in kedro_cli.py
where all “frameworky” decisions are made, but now it is hidden (and undocumented), and the user is no longer able to change it.
Context
Working on a project where src
does not exist - I would like to modify the python path myself (or at least have control over what gets added or not)
I understand that this is probably there to make this work both in jupyter/ipython and when running cli commands - however assumptions about user code should not be in library code.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:2
- Comments:17 (12 by maintainers)
Top Results From Across the Web
[KED-1169] Library code should be framework decision agnostic
This line in library code makes assumptions about the user code (i.e. that the directory src exists). This used to be in kedro_cli.py...
Read more >David K. on Twitter: "Over-abstracting code away from a UI ...
Over-abstracting code away from a UI library causes unmaintainable legacy code, but so does tying that code completely to a UI library/framework.
Read more >What are your criteria for choosing a framework or library?
If there is an open source option that works I will always choose that, there is no better support then having the source...
Read more >How to Choose the Best Javascript Data Visualization Library
Most of the charting libraries are framework agnostic. ... as some libraries assumes that the code will only be executed in the client-side ......
Read more >Empowering Development through Framework-Agnostic ...
The client had smart developers to make the correct decisions and limiting ... While this tool ultimately bound the component library to a ......
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
We have made the source directory configurable with
source_dir
key in.kedor.yml
in https://github.com/quantumblacklabs/kedro/commit/8de924819ae7e622a5a73b00f742e77efb936438 so you can customise it likeOr
if
src
doesn’t suit your use case.It will be released in the next release, so I’m closing this issue, but do let us know if you have any questions/comments. We are still continuing on the framework redesign, so more refactoring is coming soon 😃
@philippegr Thank you for raising this! As @idanov mentioned above, our architecture change in framework code is in our plan in the first quarter of this year, mainly improving the usability of KedroContext (and
load_context
etc). Hopefully we will be able to release it at the next major releases in near future 😃