question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[KED-2131] Incomplete documentation about the Spaceflights tutorial

See original GitHub issue

Description

The docs regarding the Spaceflights tutorial are incomplete, which makes it harder to successfully finish it.

This has been partially discussed in https://github.com/quantumblacklabs/kedro-examples/issues/58 (including the issue reproducibility). Therefore, I will discuss it in a complementary way.

Context

There is apparently an ongoing internal issue about improving the organization and sync between the repos kedro-examples, kedro-training, and kedro-starter-spaceflights (https://github.com/quantumblacklabs/kedro-training/pull/1).

As I understood, spaceflight full-repo is moving from kedro-examples/kedro-tutorial to kedro-training/kedro/exercises/spaceflight.

I’m not sure about what is being tracked internally, so I will list what I’ve found related to Spaceflights’ requirements.txt:

Actionable

  1. kedro-examples/kedro-tutorial’s requirements.txt should be updated to contain kedro[pandas.CSVDataSet,pandas.ExcelDataSet].
  2. Docs should be improved to show that kedro[pandas.CSVDataSet,pandas.ExcelDataSet] is required. Set up the spaceflights project#Install project dependencies is probably the right place.
  3. This also applies to kedro-training docs at Create a new project#kedro install.
  4. Latest and stable Kedro docs points to kedro-examples as the full source to the spaceflights project. I’m not sure, but I guess that this will/should be eventually changed to kedro-training/kedro-exercises/spaceflight.

I could work on 1., 2., and 3. if it makes sense (note that they are at 3 different repos).

PS: Sorry for the cross-repos references everywhere. I considered that here was the best place to report it.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
falcaopetricommented, Sep 28, 2020

Thanks for addressing it, @921kiyo.

If there is still time, I’d like to add three more notes regarding the docs and kedro-training:

shuttles:
  type: kedro_tutorial.io.xls_local.ExcelLocalDataSet
  filepath: data/01_raw/shuttles.xlsx
  layer: raw
0reactions
lorenabalancommented, Nov 27, 2020

Closing this as resolved through linked PRs/issues, as well as https://github.com/quantumblacklabs/kedro/commit/589d6a7a329f453ac91662814ec044dc41d1063c and https://github.com/quantumblacklabs/kedro/commit/0fd6b623bdaa2f69623ad4fdacb022a5862fb590 . Please feel free to open a new issue if there are other observations!

Read more comments on GitHub >

github_iconTop Results From Across the Web

[KED-2131] Incomplete documentation about the Spaceflights ...
Description The docs regarding the Spaceflights tutorial are incomplete, which makes it harder to successfully finish it.
Read more >
Kedro spaceflights tutorial — Kedro 0.18.4 documentation
In this tutorial, we construct nodes and pipelines for a price-prediction model to illustrate the steps of a typical Kedro workflow. In the...
Read more >
Spaceflights Tutorial Part 1 - Writing Data Pipelines with Kedro ...
Data Engineering is a tough job, and it can be made tougher by complex, difficult to understand data pipelines. In this series, we...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found