question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove "Tags" from datasets

See original GitHub issue

Note. Good starter task for anyone wanting to get more familiar with kedro-viz!

Along similar lines to https://github.com/kedro-org/kedro-viz/issues/962

Currently every single graph node on kedro-viz has a Tags field: image

In reality, however, only kedro nodes can have tags. Datasets, transcoded datasets and parameters should not have this field.

  1. Move tags from being a field in the base model flowchart.GraphNode to only in the kedro node model flowchart.TaskNode
  2. Remove tags from instantiations of the non-TaskNode models, e.g. calls to GraphNode.create_parameters_node should no longer have a tags argument (you’ll see it’s currently just set to set() anyway)
  3. Remove tags field from the frontend for everything but a task node

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
rashidakanchwalacommented, Sep 27, 2022

@AntonyMilneQB – had a brief discussion with @tynandebold on this. The above suggested implementation to move tags from flowchart.GraphNode to flowchart.TaskNode is affecting the filtering as it’s no longer showing any dependent datasets and maybe (subjective to users) showing an incomplete picture of the pipeline when u filter by tags.

We also realised tags are not linked to modular pipelines, so in a collapsed mode - if you click on a tag within a modular pipeline – it will say no data which is not expected behaviour. For the above 2, i think we need to create a separate ticket on how tag interactions work on FE and for this Tynan will also check on how much this feature is used.

The main goal of this ticket is to remove the unnecessary tag information from metadata panel for datasets, and parameters and only have for task node. This can be easily achieved in the front-end (via isTaskNode show Tag else don’t) without any change to BE. So maybe we just handle it that way for now.

please let me know if the above makes sense.

cc @Huongg

1reaction
tynandeboldcommented, Sep 27, 2022

So it seems we’re not tracking clicks on tags right now (maybe because they’re dynamic?) but we are tracking filtering by the element types. Here’s that data for over the past 90 days in an aggregate count (not unique):

image

Safe to say that it isn’t used too much.

Rashida, I agree with this part:

The main goal of this ticket is to remove the unnecessary tag information from metadata panel for datasets, and parameters and only have for task node. This can be easily achieved in the front-end (via isTaskNode show Tag else don’t) without any change to BE. So maybe we just handle it that way for now.

If we only do that it seems we should be safe and still solve the original issue created by Antony.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to delete a tag on dataset
I think you just have to go to the dataset(s) where that tag is stored and remove the tag from there. Then it...
Read more >
Managing Dataset Tags
Navigate to the tab All Datasets . Select a dataset. Select Tag and then choose Manage. Select a tag, choose Delete, and confirm...
Read more >
Deleting a Sequence
So Deleting a Sequence works well, get a reference to the sequence then Dataset.Remove(seq) no problem. Private sequence's get mangled to a single...
Read more >
Deleting labels | BigQuery
Deleting a table or view label · In the Google Cloud console, select the dataset. · Click the Details tab, and then click...
Read more >
TagCleaner: Identification and removal of tag sequences from ...
To our knowledge, TagCleaner is the first web application optimized to automatically detect and remove tag sequences from metagenomic datasets.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found