question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

If reviewers already assigned, skip

See original GitHub issue

We are finding it annoying when a PR requester takes care to request specific people to review a PR, then the action comes along and adds more. A great flag would be to be able to skip adding reviews if the numberOfReviewers has been met or to skip adding reviews completely in this case.

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:15
  • Comments:11 (1 by maintainers)

github_iconTop GitHub Comments

8reactions
kentaro-mcommented, Jun 13, 2020

Hi, @brianeclow! Thanks for waiting.

I thought a good idea which checking exist assignees or reviewers before adding its to PR.

  1. Checking existed reviewers
    1. Skip the process to add reviewers if PR has reviewers
  2. Adding reviewers if no reviewers
  3. Checking existed assignees
    1. Skip the process to add assignees if PR has assignees
  4. Adding assignees if no assignees

I think it’s better to control the skipping process as the logic of the application rather than the if syntax of the workflow.

If you have any concerns, please let me know.

4reactions
vistaar-dgadacommented, Apr 13, 2020

@brianeclow //cc @kentaro-m You’re searching for action to run only once. Usually it runs on every push on PR. So i think this will take care of it.

name: 'Auto Assign'
on:
  pull_request:
    types: [opened, reopened]
jobs:
  add-reviews:
    runs-on: ubuntu-latest
    steps:
      - uses: kentaro-m/auto-assign-action@v1.0.1
        with:
          repo-token: "${{ secrets.GITHUB_TOKEN }}"
Read more comments on GitHub >

github_iconTop Results From Across the Web

Redistributing Incomplete Reviewing Assignments from One ...
Answer: · Remove any unsubmitted reviews (including Saved/Drafted reviews) from the locked reviewer and assign those reviews to other members of the same...
Read more >
Managing code review settings for your team - GitHub Docs
Optionally, to always skip certain members of the team, select Never assign certain team members. Then, select one or more team members you'd...
Read more >
How do I uninvite Reviewers in Editorial Manager?
After a reviewer has agreed, or if the reviewer was assigned without invitation, they can be unassigned. Uninvite and Unassign statistics are ...
Read more >
Reviewer access - Relativity Documentation
If you don't want reviewers to skip documents, make the project review field a required field. We recommend turning off family propagation with...
Read more >
Monitor reviewers' progress and assess incoming reviews
You must first assign and invite at least one reviewer. If you are not already on the Review screen, navigate to the Journal...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found