Importing mdx files from node_modules doesn't work

Hi ! Thanks for this neat tool !

I’d like to use it to do some transclusion of Mdx files, some of which I would like to manage as individual npm packages.

My understanding of the comment below is that this should work out of the box: https://github.com/kentcdodds/mdx-bundler/blob/2802158695c86fa6e8cc271bb1fb62466bdf22ee/src/index.js#L150-L157

But I can’t make it work …

I’ve created a new test case in my fork to illustrate:

test('bundles mdx files from node_modules', async () => {
  const mdxSource = `
import MdxTestData from 'mdx-test-data'
The content below was imported from an MDX File in node_modules.
<MdxTestData />
  `.trim()

  const result = await bundleMDX(mdxSource, {
    files: {},
  })

  const Component = getMDXComponent(result.code)
  render(React.createElement(Component))
})

mdx-test-data is a package that simply exposes README.mdx in the main field of package.json

And running this test yields this result:

   FAIL  "bundles mdx files from node_modules"
    Build failed with 1 error:
__mdx_bundler_fake_dir__/_mdx_bundler_entry_point.mdx:2:24: error: No loader is configured for ".mdx" files: node_modules/mdx-test-data/README.mdx

    __mdx_bundler_fake_dir__/_mdx_bundler_entry_point.mdx:2:24: error: No loader is configured for ".mdx" files: node_modules/mdx-test-data/README.mdx
    at failureErrorWithLog (C:/Users/gaelh/dev/mdx-bundler/node_modules/esbuild/lib/main.js:1432:15)
    at C:/Users/gaelh/dev/mdx-bundler/node_modules/esbuild/lib/main.js:1114:28
    at runOnEndCallbacks (C:/Users/gaelh/dev/mdx-bundler/node_modules/esbuild/lib/main.js:912:47)
    at buildResponseToResult (C:/Users/gaelh/dev/mdx-bundler/node_modules/esbuild/lib/main.js:1112:7)
    at C:/Users/gaelh/dev/mdx-bundler/node_modules/esbuild/lib/main.js:1219:14
    at C:/Users/gaelh/dev/mdx-bundler/node_modules/esbuild/lib/main.js:603:9
    at handleIncomingPacket (C:/Users/gaelh/dev/mdx-bundler/node_modules/esbuild/lib/main.js:700:9)
    at Socket.readFromStdout (C:/Users/gaelh/dev/mdx-bundler/node_modules/esbuild/lib/main.js:570:7)
    at Socket.emit (events.js:315:20)

Am I missing something ? Is there another way of importing mdx files from node_modules ?

[Arcath]

@gaelhameon returning an empty object should work as I interpret the docs.

I have seen some behaviour in esbuild where if a plugin returns anything it gets first dibs on the next phase, but that should still have passed over to xdmEsbuild when the inMemory onLoad callback returned {}

Bit strange.

[gaelhameon]

@Arcath , yes, 4.0.0 has fixed this for me. Thanks !