Docker build broken in current master

Running the Docker build is currently broken in master and also in 0.6.1 (but not in 0.6.0).

Command:

docker build .

Error:

Step 20/37 : COPY --from=builder /opt/grobid-source/grobid-core/build/libs/grobid-core-*-onejar.jar ./grobid/grobid-core-onejar.jar
 ---> f50b25031de8
Step 21/37 : COPY --from=builder /opt/grobid-source/grobid-service/build/distributions/grobid-service-*.zip ./grobid-service.zip
COPY failed: no source files were specified

This seems to be caused by https://github.com/kermitt2/grobid/commit/683804d31eb5635468c93195a0bf79d7f91db1ed which disabled the creation of the distribution zip.

Might be good to add the Docker build as part of the CI build.

/cc @lfoppiano

[lfoppiano]

Yes that was before we migrated to gradle 6, I think with the install it was creating the zip file if I’m not wrong. Anyway, it seem that this change would fix this two issues in one go. So 👍.

[de-code]

Might be good to add the Docker build as part of the CI build.

This would make each CI build at 40 minutes or more, so degrading a lot the interest of the CI.

40 minutes seem to be a bit high, why do you think that? The build for #629 (https://travis-ci.org/github/kermitt2/grobid/builds/721804752) ran for for over 7 minutes without Docker and over 8 minutes with Docker (although no tests in that case). The main difference is that caching artefacts across builds would be more difficult. I believe one way of doing it if it seems worth it, is to push / pull layers of the image (as the cloud CI servers don’t usually cache layers out of the box). I get more information on that (a colleague of mine used it for some project I believe).