Unable to patch urllib2 after install_opener has been used.

We’re using a custom opener with urllib2 (adding some additional sec features), looks something like so:

urllib2.install_opener(urllib2.build_opener(CustomHTTPSOpener))

The opener overwrites the https_open method so that a custom connection object can be used. Something like the following:

class CustomHTTPSOpener(urllib2.HTTPSHandler):
    def __init__(self, **kwargs):
        urllib2.HTTPSHandler.__init__(self)
        self._connect_args = kwargs

    def https_open(self, req):
        def connection_wrapper(host, **kwargs):
            all_kwargs = dict(self._connect_args)
            all_kwargs.update(kwargs)
            return CustomHTTPSConnection(host, **all_kwargs)

        return self.do_open(connection_wrapper, req)

Then when I use vcrpy, I get the following:

TypeError: unbound method __init__() must be called with VCRHTTPConnection myapp/tests/cassette.yaml instance as first argument (got CustomHTTPSConnection instance instead)

Any ideas? Thanks

[IvanMalison]

@tiffanycheng @breerly https://github.com/kevin1024/vcrpy/pull/133 should enable the behavior that you want.

All that you really need to do is use a custom vcr for patching that looks like:

from vcr.stubs import VCRHTTPSConnection
my_vcr = config.VCR(custom_patches=((wherever_it_lives, 'CustomHTTPSConnection', VCRHTTPSConnection),))

Can you test this and let me know if I can close this issue?

[IvanMalison]

cool. I’m going to close this issue for now. Let me know if there are any more problems.