question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve icon generation to reduce cutoff

See original GitHub issue

Follow-up of #40 Thanks to https://github.com/kevinmarrec/nuxt-pwa-module/commit/8c1f8e2c715ca1416d5d3c6d4a7059fe49f8a99b, the generation is running through now but the icon is cut off when height > width.

It’d be ideal to termine whether height > width, then running sharp(input).resize(undefined, Math.floor(size)) and else running ``sharp(input).resize(Math.floor(size))`


Result with current state:

grafik

Result with (harcoded) patch:

grafik

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
kevinmarreccommented, Oct 1, 2022

@manniL Thanks, I found a better way to handle it, and also made splashs working with all icon sizes !

Closing through https://github.com/kevinmarrec/nuxt-pwa-module/commit/f342fa895110ad4525c8e46a9ca5574413dc4b15

Released in v0.6.1

1reaction
kevinmarreccommented, Oct 1, 2022

Yeah I didn’t know what to do regarding not squared icons, if undefined on resize function works well I’m gonna do adjustments.

Thanks for feedback !

Read more comments on GitHub >

github_iconTop Results From Across the Web

Icon-font cuts off top of icon - Stack Overflow
Sadly the upper part of the icon get's cropped off. I found out, that the icon-font I'm using is adding a ::after-pesudo-element which...
Read more >
Icons look cut off in Application manager - avid.force.com
Steps · 1. You can fix this by changing the Application settings in Windows. · 2. Click the Compatibility Tab. · 3. Click...
Read more >
These 2 icons are cut off after Android 12 update (OnePlus 8)
These 2 icons are cut off after Android 12 update (OnePlus 8) ... necessary to improve the UI and the menues that are...
Read more >
Create app icons with Image Asset Studio - Android Developers
Image Asset Studio helps you generate the following icon types: ... With crop, the image edges can be cut off, and with shrink,...
Read more >
Cutoff Finder: A Comprehensive and Straightforward Web ...
However, methods for cut-off determination vary among published ... The track below the icons refers to the places where the steps of data ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found