Ical.js under CommonJS (Node.js) leaks global ICAL variable

Hey,

Noticed some of my tests failing because they spot a global variable leakage. Turns out https://github.com/mozilla-comm/ical.js/blob/f3b8c7dc24a66424feb1735fe7ff38191e46ab99/lib/ical/helpers.js#L11 sets a global ICAL that is entirely unnecessary when running under CommonJS modules like when ran under Node.js. That ICAL variable should be scoped somehow to not set undesired globals. 😉

Cheers

[kewisch]

#470 should fix most of this, the rest via es6 modules which is work in progress

[mediaessenz]

I have exacly the same problem in conjuction with fullcalender.io’s icalendar plugin, which uses this lib as well. It took me hours to find the reason and using the same workaround than @pscs now, which i find quite ugly as well.

To help other people who have the same problem, here is the exact error, i got in the js console: “Uncaught ReferenceError: assignment to undeclared variable ICAL”

To fix it, i changed line 11 of node_modules/ical.js/build/ical.js from

ICAL = module.exports;

to

var ICAL = module.exports;