IllegalArgumentException on canceled Account Linking

Describe the bug

When the login on my external IDP gets canceld it sends an error=access_denied back to keycloak.

Upon regular login, keycloak can deal with such an error. But when I try client-initiated-account-linking, I get redirected to the unexpected-error-page with an exception in the keycloak logs.

Version

16.0.0

Expected behavior

• redirect to the client
• no exceptions in the keycloak log

Actual behavior

• redirect to the unexpected-error-page
• the following exception is shown in the keycloak logs

06:58:11,530 ERROR [org.keycloak.broker.oidc.AbstractOAuth2IdentityProvider] (default task-14) access_denied for broker login oidc 06:58:11,536 WARN [org.keycloak.services] (default task-14) KC-SERVICES0013: Failed authentication: java.lang.IllegalArgumentException: response_type is null at org.keycloak.keycloak-services@14.0.0//org.keycloak.protocol.oidc.utils.OIDCResponseType.parse(OIDCResponseType.java:48) at org.keycloak.keycloak-services@14.0.0//org.keycloak.protocol.oidc.OIDCLoginProtocol.setupResponseTypeAndMode(OIDCLoginProtocol.java:155) at org.keycloak.keycloak-services@14.0.0//org.keycloak.protocol.oidc.OIDCLoginProtocol.authenticated(OIDCLoginProtocol.java:202) at org.keycloak.keycloak-services@14.0.0//org.keycloak.services.managers.AuthenticationManager.redirectAfterSuccessfulFlow(AuthenticationManager.java:921) at org.keycloak.keycloak-services@14.0.0//org.keycloak.services.managers.AuthenticationManager.redirectAfterSuccessfulFlow(AuthenticationManager.java:869) at org.keycloak.keycloak-services@14.0.0//org.keycloak.services.managers.AuthenticationManager.finishedRequiredActions(AuthenticationManager.java:1022) at org.keycloak.keycloak-services@14.0.0//org.keycloak.authentication.AuthenticationProcessor.authenticationComplete(AuthenticationProcessor.java:1086) at org.keycloak.keycloak-services@14.0.0//org.keycloak.authentication.AuthenticationProcessor.authenticate(AuthenticationProcessor.java:854) at org.keycloak.keycloak-services@14.0.0//org.keycloak.services.resources.IdentityBrokerService.browserAuthentication(IdentityBrokerService.java:1193) at org.keycloak.keycloak-services@14.0.0//org.keycloak.services.resources.IdentityBrokerService.cancelled(IdentityBrokerService.java:858) at org.keycloak.keycloak-services@14.0.0//org.keycloak.broker.oidc.AbstractOAuth2IdentityProvider$Endpoint.authResponse(AbstractOAuth2IdentityProvider.java:491) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at [e-mail]//org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:138) at [e-mail]//org.jboss.resteasy.core.ResourceMethodInvoker.internalInvokeOnTarget(ResourceMethodInvoker.java:546) at [e-mail]//org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTargetAfterFilter(ResourceMethodInvoker.java:435) at [e-mail]//org.jboss.resteasy.core.ResourceMethodInvoker.lambda$invokeOnTarget$0(ResourceMethodInvoker.java:396) at [e-mail]//org.jboss.resteasy.core.interception.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:358) at [e-mail]//org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTarget(ResourceMethodInvoker.java:398) at [e-mail]//org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:365) at [e-mail]//org.jboss.resteasy.core.ResourceLocatorInvoker.invokeOnTargetObject(ResourceLocatorInvoker.java:150) at [e-mail]//org.jboss.resteasy.core.ResourceLocatorInvoker.invoke(ResourceLocatorInvoker.java:110) at [e-mail]//org.jboss.resteasy.core.ResourceLocatorInvoker.invokeOnTargetObject(ResourceLocatorInvoker.java:141) at [e-mail]//org.jboss.resteasy.core.ResourceLocatorInvoker.invoke(ResourceLocatorInvoker.java:104) at [e-mail]//org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:440) at [e-mail]//org.jboss.resteasy.core.SynchronousDispatcher.lambda$invoke$4(SynchronousDispatcher.java:229) at [e-mail]//org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:135) at [e-mail]//org.jboss.resteasy.core.interception.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:358) at [e-mail]//org.jboss.resteasy.core.SynchronousDispatcher.preprocess(SynchronousDispatcher.java:138) at [e-mail]//org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:215) at [e-mail]//org.jboss.resteasy.plugins.server.servlet.ServletContainerDispatcher.service(ServletContainerDispatcher.java:245) at [e-mail]//org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:61) at [e-mail]//org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:56) at [e-mail]//javax.servlet.http.HttpServlet.service(HttpServlet.java:590) at [e-mail]//io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74) at [e-mail]//io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129) at org.keycloak.keycloak-wildfly-extensions@14.0.0//org.keycloak.provider.wildfly.WildFlyRequestFilter.lambda$doFilter$0(WildFlyRequestFilter.java:41) at org.keycloak.keycloak-services@14.0.0//org.keycloak.services.filters.AbstractRequestFilter.filter(AbstractRequestFilter.java:43) at org.keycloak.keycloak-wildfly-extensions@14.0.0//org.keycloak.provider.wildfly.WildFlyRequestFilter.doFilter(WildFlyRequestFilter.java:39) at [e-mail]//io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) at [e-mail]//io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131) at [e-mail]//io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84) at [e-mail]//io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62) at [e-mail]//io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68) at [e-mail]//io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36) at [e-mail]//org.wildfly.extension.undertow.security.SecurityContextAssociationHandler.handleRequest(SecurityContextAssociationHandler.java:78) at [e-mail]//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at [e-mail]//io.undertow.servlet.handlers.RedirectDirHandler.handleRequest(RedirectDirHandler.java:68) at [e-mail]//io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:117) at [e-mail]//io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57) at [e-mail]//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at [e-mail]//io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46) at [e-mail]//io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64) at [e-mail]//io.undertow.security.handlers.AuthenticationMechanismsHandler.handleRequest(AuthenticationMechanismsHandler.java:60) at [e-mail]//io.undertow.servlet.handlers.security.CachedAuthenticatedSessionHandler.handleRequest(CachedAuthenticatedSessionHandler.java:77) at [e-mail]//io.undertow.security.handlers.NotificationReceiverHandler.handleRequest(NotificationReceiverHandler.java:50) at [e-mail]//io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43) at [e-mail]//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at [e-mail]//org.wildfly.extension.undertow.security.jacc.JACCContextIdHandler.handleRequest(JACCContextIdHandler.java:61) at [e-mail]//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at [e-mail]//org.wildfly.extension.undertow.deployment.GlobalRequestControllerHandler.handleRequest(GlobalRequestControllerHandler.java:68) at [e-mail]//io.undertow.servlet.handlers.SendErrorPageHandler.handleRequest(SendErrorPageHandler.java:52) at [e-mail]//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:269) at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler.access$100(ServletInitialHandler.java:78) at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:133) at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:130) at [e-mail]//io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48) at [e-mail]//io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43) at [e-mail]//org.wildfly.extension.undertow.security.SecurityContextThreadSetupAction.lambda$create$0(SecurityContextThreadSetupAction.java:105) at [e-mail]//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1530) at [e-mail]//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1530) at [e-mail]//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1530) at [e-mail]//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1530) at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:249) at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler.access$000(ServletInitialHandler.java:78) at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:99) at [e-mail]//io.undertow.server.Connectors.executeRootHandler(Connectors.java:387) at [e-mail]//io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:841) at [e-mail]//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at [e-mail]//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990) at [e-mail]//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) at [e-mail]//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377) at [e-mail]//org.xnio.XnioWorker$WorkerThreadFactory$1$1.run(XnioWorker.java:1280) at java.base/java.lang.Thread.run(Thread.java:829)

How to Reproduce?

• start the client-initiated-account-linking
• abort with error=access_denied

Anything else?

This is a Copy of the RedHat-Issue 18584

[ch-lepp]

@lexcao and @mposolda

Thanks for looking into the problem. But I think you misidentified the root cause.

The IDP returns an error response as described in rfc 6749. This means, there is only an ‘error’ and a ‘state’ param present in the response.

But as you can see in my stack trace, keycloak expects a ‘response type’ param and throws an exception when not finding one.

This is independent of the theme used. And it is still happening in keycloak version 19.

What I think might be causing the problem: The cancelled method is called properly. But for some reason, this method still leads me to the browser authentication flow, even though I am already authenticated to keycloak.

[gsedlacz]

More detailed repro steps to avoid further mixups:

Make sure the client initiating the account linking has consentRequired: true set.

1. login to the account console
2. initiate the account linking process from within your client (might be a account console instance or any other application)
3. (skips the login in keycloak as you are already logged in - if you skip step one will be asked to login now - neither workflow works tho)
4. click no on the login-oauth-grant.ftl UI
5. -> error UI

---

In addition to that I noticed that the login (if not logged in yet) does not create a login session in this workflow.