A select with number at start of value throws an error

Bug report

Describe the bug

If you create a list with numbers at the start of the value of will throw an error on start.

message: 'Syntax Error: Expected Name, found Int "0"',

To Reproduce

1. Create a list like:

keystone.createList('ExampleList', {
  fields: {
    age: {
      type: Select,
      options: '0-18,19-35,36-50,50+',
    },
  },
});

1. Start Keystone.

It doesn’t seem to matter if you use the array notation either:

keystone.createList('ExampleList', {
  fields: {
    age: {
      type: Select,
      options: [
        { label: '0-18', value: '0-18' },
        { label: '19-35', value: '19-35' },
        { label: '36-50', value: '36-50' },
        { label: '50+', value: '50+' },
      ],
    },
  },
});

Expected behaviour

I can’t see a clear reason why this cannot work. There are no limitations on storing this in a text field in the DB or on the possible values in HTML.

System information

I was using Knex Adapter

Additional context

Is Monday.

[timleslie]

Solution options:

1. Continue to use enum and generate better error messages and provide more explicit docs.
2. Change our implementation away from using enum to support a broader range of options. This would require a major breaking change and would require a significant change to how we handle this field type. I’m not sure there are any good reasons to do this, but it’s something we should discuss.

Implementing the docs and error messages in option 1) is something we can and should do before we make a final decision on option 2).

[MadeByMike]

I really think the solution is to fix this even if it’s a breaking change. It makes no senses to limit the types of data that people can put in the value of a select. I need to understand more about how this is a breaking change.