Error uploading to S3 using read streams and putObject

Bug report

I was trying to use the S3 adapter to upload files in the admin api using the File field type. When attempting to upload the file I would get a ‘nested errors’ message. There wouldn’t be anything in the CLI log where the app was running. I had make my own version of the adapter in a stand-alone project locally to debug this. Essentially, the file is getting a read stream and the putObject method of the AWS SDK expects a binary string. This can be resolved by using the upload method as it is smart and can handle read streams. I can prepare a PR if you would like.

To Reproduce

Steps to reproduce the behaviour. Please provide code snippets or a repository:

1. Setup S3 file adapter like demonstrated in the documentation.
2. Try to upload file
3. Error

Expected behaviour

Uploading a file should work

Screenshots

System information

• OS: Linux (Docker)

Additional context

https://github.com/keystonejs/keystone/blob/1d7f2e62756f054f0b2ba1c34043387e9f945393/packages/file-adapters/lib/s3.js#L39

[BitForger]

@LiamAttClarke #2249 is exactly what I did to fix it.

[LiamAttClarke]

According to the docs, s3.putObject accepts “Buffer, Typed Array, Blob, String, ReadableStream”.

https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#putObject-property

That said, I agree that the s3.upload method would be better.