AddNewtonsoftJson and ProblemDetails, .Net Core 3

I am having problems using Newtonsoft as the json serializer (using AddNewtonsoftJson in startup) with problem details. When this package returns the problem details the Extensions property is serialzied as "Extensions": {...} and not to the parent. If I in a controller use return Problem(detail: "test"); the Extensions property is serialized correctly.

The Microsoft.AspNetCore.Mvc.ProblemDetails has a JsonExtensionDataAttribute on the property, but since it is .Net Core 3.0 it is in the namespace System.Text.Json.Serialization.

This issue might not be specific for this package but I need to start somewhere.

[khellang]

I’ve pushed a new version, v5.0, to NuGet, where I’ve removed all internal usage of custom sub-types in the middleware. Hopefully this means that the built-in converters should wrap the instances in AnnotatedProblemDetails and make Newtonsoft.Json pick up the attributes 🤞

[khellang]

Hi @emilssonn! 👋

Hmm. The AddNewtonsoftJson extension should add a special ProblemDetailsConverter that takes care of wrapping Microsoft.AspNetCore.Mvc.ProblemDetails in a special wrapper type that utilizes the Newtonsoft.Json-specific JsonExtensionData attribute. See https://github.com/aspnet/AspNetCore/blob/c565386a3ed135560bc2e9017aa54a950b4e35dd/src/Mvc/Mvc.NewtonsoftJson/src/ProblemDetailsConverter.cs#L45 and https://github.com/aspnet/AspNetCore/blob/c565386a3ed135560bc2e9017aa54a950b4e35dd/src/Mvc/Mvc.NewtonsoftJson/src/AnnotatedProblemDetails.cs.

I wonder what’s going wrong here. Maybe releasing a version targeting netcoreapp3.0 and the Microsof.AspNetCore.App FrameworkReference would solve this? @pranavkm?