FromExecutingAssembly and FromCallingAssembly are misleading

FromExecutingAssembly and FromCallingAssembly are misleading. The naming suggests that it will use the assemblies from the perspective of where it is being called, but actually uses scrutor’s perspective.

https://github.com/khellang/Scrutor/blob/master/src/Scrutor/TypeSourceSelector.cs#L20

        public IImplementationTypeSelector FromCallingAssembly()
        {
            return FromAssemblies(Assembly.GetCallingAssembly());
        }

        public IImplementationTypeSelector FromExecutingAssembly()
        {
            return FromAssemblies(Assembly.GetExecutingAssembly());
        }

Because these methods are defined in Scrutor, the resulting assemblies will be:

• FromCallingAssembly will use the assembly that called Scrutor, rather than the actual calling assembly.
• FromExecutingAssembly will use Scrutor’s assembly. Always.

In other words,

• scan.FromCallingAssembly === scan.FromAssemblies(Assembly.GetExecutingAssembly())
• scan.FromExecutingAssembly === scan.FromAssemblies(typeof(Scrutor).Assembly)

[MisinformedDNA]

Here’s my simple workaround:

services.Scan(s => s.FromAssemblies(Assembly.GetExecutingAssembly())

[MisinformedDNA]

Got stuck on this again. For CallingAssembly, I needed to do

var assembly = Assembly.GetCallingAssembly();
services.Scan(s => s.FromAssemblies(assembly));

Otherwise, the calling assembly ends up being Scrutor.