question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Hello, @Kiarash-Z! Thanks a lot for your work, 2.1.0 do exactly what I need.

But there are some bugs:

  1. weekStartingIndex do the work, calendar is now with the right shift. But our weekends are not correct. Don’t it need to be shifted too? I will disable -weekend styling for now (May be add prop for it’s color like colorPrimary? 😃

2 If you pass locale prop and do not provide getToday, toNativeDate and other functions - calendar will crash.

Example

  1. Please, add customizing weekDays-shortings. At Russia we have 2 letters in it, not just 1. But may be it will be good to provide custom array, just like months and weekDays.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:11 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
iksentcommented, Jan 22, 2020

Hello, @Kiarash-Z. I figure out the problems at IE11 and suggest the easiest way: Change your code a bit and write a guide on how to make compatibility with IE11.

CHANGES

  1. IE not supports classList.replace https://github.com/iksent/react-modern-calendar-datepicker/commit/2bfd5a353e68142260d92538ffd0a8457924caa1#diff-889c05195b2178fd3b2544b3a84b4d3b

  2. Wrapper CSS https://github.com/iksent/react-modern-calendar-datepicker/commit/2bfd5a353e68142260d92538ffd0a8457924caa1#diff-e4c3a4057dcc5b72d029273600da5c33

  3. Buttons CSS https://github.com/iksent/react-modern-calendar-datepicker/commit/907749ad45f000fd870c4e6d5ab0bdd35ccf5b29

  1. DatePicker with input: Calendar will be closed when clicking at any place inside Calendar

Can’t fix it by now, multiple onBlur events firing at IE11.

GUIDE (Inside developers’ projects)

  1. IE not supports CSS variables. Can be fixed, for example, with css-vars-ponyfill

Example with default values:

cssVars({
  onlyLegacy: true, // Modern browsers uses props
  variables: {
    '--cl-color-primary': '#0eca2d',
    '--cl-color-primary-light': '#cff4d5',
    '--animation-duration': '0.4s',
    '--cl-color-black': '#444444',
    '--cl-color-disabled': '#d4d4d4',
    '--cl-color-error': '#ff2929',
  },
});
  1. Polyfills for IE
  • Array.from
  • Array.find
  • Array.keys
<script crossorigin="anonymous" src="https://polyfill.io/v3/polyfill.min.js?features=Array.prototype.keys%2CArray.from%2CArray.prototype.find"></script>

P.S.: Sorry, had no time to create PRs.

1reaction
Kiarash-Zcommented, Jan 19, 2020

@iksent IE is not important anymore. We’re living in 2020. Unless you build your applications for dinosaurs, IE doesn’t matter. Many huge companies like Apple don’t support IE in for their website and they encourage you to use a newer browser…

Read more comments on GitHub >

github_iconTop Results From Across the Web

Qimera 2.1.0 - Bugs - Qimera - QPS Confluence
Qimera 2.1.0 - Bugs ; Surfaces - Static - Crash after trying to import second grid ; Cross check graphs do not display...
Read more >
Release version 2.1.0 · Issue #1771 · opensearch ... - GitHub
Find/fix bugs using latest tarball and docker image provided in parent release issue and update the release notes if necessary. Code Complete: ...
Read more >
Known Issues and trouble-shooting - WIPO
Key Description Components Affect... ST26T‑2900 Event Viewer errors when launching WIPO Sequence WIPO Sequence 2.1.0 ST26T‑2910 Auto‑update does not download the latest binary WIPO Sequence...
Read more >
ConstraintLayout 2.1.0 beta 1 - Android Studio Release Updates
We are happy to announce the release of ConstraintLayout 2.1.0 beta 1, with many new features :) dependencies {.
Read more >
MX4J / Bugs / Group Release 2.1.0 - SourceForge
#. Sort A ‑> Z; Sort Z ‑> A Summary▾. Sort A ‑> Z; Sort Z ‑> A 206 Blank page when an attribute...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found