404s get cached and provided as 200

Hi!

I followed the next.js ssr-caching example, so I’ve got a route like this:

server.get('/product/:handle', (req, res) => { const queryParams = { handle: req.params.handle }; const pagePath = '/product/' + req.params.handle'; return ssrCache({ req, res, pagePath, queryParams }); });

When a non-existent handle gets hit, the server responds with 404 but the second time it’s 200. How can I prevent this?

[Kikobeats]

done at https://github.com/Kikobeats/cacheable-response/commit/649de67300be5fe61b8562e4cd9f7b3c77a521be ✨

[Kikobeats]

In the current implementation, you can avoid store a value into the cache if you return undefined or null: https://github.com/Kikobeats/cacheable-response/blob/master/index.js#L85

so, if in your code workflow you return one of these values under your 404 error, then it should be enough to don’t store it into the cache.

Can you confirm me that workflow works?