Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Implement missing overdue conditions

See original GitHub issue

There are a number of possible overdue conditions that can be selected but only a few have been implemented.

Recently with the work of #256, we can now specify inclusion or exclusion tags (ControlTagType). The remaining conditions (unimplemented or untested) are:

totalUnpaidInvoiceBalanceEqualsOrExceeds
timeSinceEarliestUnpaidInvoiceEqualsOrExceeds
responseForLastFailedPaymentIn

Issue Analytics

State:
Created 7 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

sbrossiecommented, Sep 14, 2016

@javier-gomez-hs Forget about the responseForLastFailedPayment for now, this is a more complicated topic and we are missing some pieces of infrastructure to get that right. I will also ping Joe to understand if they have more requirements from their side for dunning/overdue (since you are working on that, this seems like the right time).

1reaction

sbrossiecommented, Sep 8, 2016

If you look at the possible set of overdue conditions, only getTimeSinceEarliestUnpaidInvoiceEqualsOrExceeds and (because of recent code change in #256) getInclusionControlTagType, getExclusionControlTagType have been tested.

The other 3 listed above have never been tested (and so i don’t even know if logic is fully implemented). The work is to write test cases for each of those (and if needed implement the unimplemented pieces). Does that make sense?