Revisit the credit story for HA parent

In the HA (Hierarchical Account) model, when a child delegates its payment to its parent, the parent must first build a summary invoice (one for all its dependent children on any given day). Today this is built by adding a new PARENT_SUMMARY invoice item for each child and the amount is the child invoice amount.

This model therefore includes any credit that child may have on the parent summary invoice , and this probably does not make sense as we don’t want to use a given child’s credit at the parent level by default.

The proposal is the following:

• Credits are not by default visible at the parent level
• We have a new api which allow to move a given child credit to the parent level (to support the use case when for instance a child cancels his subscription and is left with some ‘recognizable credit’.

[sbrossie]

@maguero I would suggest a test-driven approach here (write scenario for each case) and see what happens with current implementation. I’d like @pierre to also review those use cases (he is off until the end of the week). After that, you can submit a proposal on what is the best course of action to modify the code (i think you are on the track track:we probably need new dedicated methods in InvoiceCalculatorUtils but this is probably not enough to achieve the result.

[sbrossie]

No problem, I can fix it.

Ah ah, you even had a comment 😉

So proposal is to add an ADJ item on the COMMITTED invoice (symetric to what happens to child invoice)

1. Current process is updating PARENT_SUMMARY item if parent invoice is DRAFT (not adding items… just updating amount value). Do you want to keep this behaviour? Test Assert

Yes

1. Do we have a way to identify to which child account is referred the ADJ item added into Parent Invoice when it’s COMMITTED but not paid yet.

You should have all the info you need to create the new ItemAdjInvoiceItem item (you have access to child account parent account and child invoice) on the parent invoice. However, when you create the ItemAdjInvoiceItem, make sure the linkedItemId points to the SUMMARY item for the child invoice (similar to what happens on the child invoice). Does that answer your question?