question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Change in image.js of quill (node modules) doesn't reflect any change

See original GitHub issue

I want to add an another attribute data-id to . I did following thing

  1. Make a change in image.js of quill (node modules)
class Image extends Parchment.Embed {
  static create(value) {
    let node = super.create(value);
    if (typeof value === 'string') {
      console.log(value);
      node.setAttribute('src', this.sanitize(value.src));
      node.setAttribute('data-id', this.sanitize(value.id));
    }
    return node;
  }
  1. In my component
let obj={
          src:url,id:data.data.data.id
        };
        console.log(obj);
        this.editorInstance.insertEmbed(this.editorRangeIndex, 'image',obj,"user");
        this.editorInstance.setSelection(this.editorRangeIndex + 1);

Nothing will happen. (Even after deleting image.js file from quill) Rewriting using Image Bolt is a solution . But I want to know what is wrong in this step.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
KillerCodeMonkeycommented, Oct 4, 2020

Why would you change the quill lib? By your self?

You should not do that…

And in General The umd bundle of quilljs is used… So Changes in image.js would lead to nothing.

satish666 notifications@github.com schrieb am So., 4. Okt. 2020, 20:16:

Custom bolt is not an issue. ngx-quill require quill 1.3.6 . So any change in quill will affect its performance. But nothing happen when i made any change in image.js.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/1049#issuecomment-703294392, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YGENVSC5BW34V53JFDSJC3WLANCNFSM4SD3C47Q .

0reactions
KillerCodeMonkeycommented, Oct 4, 2020

You can Close the issue again since ist hast nothing To-Do with ngx-quill.

Just ask at quilljs repo how to add custom Attributes 😉.

satish666 notifications@github.com schrieb am So., 4. Okt. 2020, 20:44:

Reopened #1049 https://github.com/KillerCodeMonkey/ngx-quill/issues/1049 .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/1049#event-3837836985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YDMC7CDZY7CXJ4OHODSJC67VANCNFSM4SD3C47Q .

Read more comments on GitHub >

github_iconTop Results From Across the Web

React : Change in node_modules file does not reflect the ...
I want to do changes in node_modules folder. Now when I run npm run watch or npm run dev it doesn't get reflected...
Read more >
Image Resize · Issue #104 · quilljs/quill - GitHub
I cant seem to import/register it in my quill, how to import this module? Does it need recompiling/packing? I copied your js files...
Read more >
quill-image-edit-module - npm
A module for Quill rich text editor that allows editing of images. ... are no other projects in the npm registry using quill-image-edit-module....
Read more >
Build a WYSIWYG text editor using Quill - LogRocket Blog
Today, we'll build a WYSIWYG text editor in React using Quill. ... After, change your working directory to the newly created project folder ......
Read more >
field 'browser' doesn't contain a valid alias configuration angular
In my library I have a common input, it all works fine in the project component, but when trying to import the mock...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found