Negative numerics issue

Description

Hi, I found an issue with negative numerics. Could you fix it please?

Steps to reproduce

1. Create test table CREATE TABLE tmp_DecimalTest ( FixedDateDate,Amount1Decimal(16,4),Amount2Decimal(20,8),Amount3 Decimal(22,10) ) ENGINE = MergeTree PARTITION BY toYYYYMM(FixedDate) ORDER BY FixedDate SETTINGS index_granularity = 8192;

2. Fill the table using code below: `using ClickHouse.Ado; using System; using System.Collections; using System.Collections.Generic;

namespace ClickHouseDecimalTest { class Program { private static string _connectionString = “************************;”;

    static void Main(string[] args)
    {
        var list = new List<MyPersistableObject>();

        list.Add(new MyPersistableObject()
        {
            MyDateField = DateTime.Now,
            MyDecimalField1 = (decimal) -100.0,
            MyDecimalField2 = (decimal) -100.0,
            MyDecimalField3 = (decimal) -100.0,
        });

        var connection = new ClickHouseConnection(_connectionString);
        connection.Open();
        var command = connection.CreateCommand();
        command.CommandText = "INSERT INTO tmp_DecimalTest (FixedDate,Amount1,Amount2,Amount3) VALUES @bulk";
        command.Parameters.Add(new ClickHouseParameter
        {
            ParameterName = "bulk",
            Value = list
        });
        command.ExecuteNonQuery();

    }
}


class MyPersistableObject : IEnumerable
{
    public decimal MyDecimalField1;
    public decimal MyDecimalField2;
    public decimal MyDecimalField3;
    public DateTime MyDateField;

    public IEnumerator GetEnumerator()
    {
        yield return MyDateField;
        yield return MyDecimalField1;
        yield return MyDecimalField2;
        yield return MyDecimalField3;
    }
}

} `

1. Check table data. Fields Amount2 and Amount2 have wrong value (see attachement)

[killwort]

1.2.5 fixes even smaller errors in numerics representation.

[killwort]

Well, there was an error for the negative decimals larger than 8 bytes. I’ve fixed that, will be released with v.1.2.3