[Window] Pressing a header command button while the window is fullscreen will make it floating

Bug Description

Pressing a header command button while the window is fullscreen will make it floating (without even changing the state).

Here is a minimal amount of code to reproduce this behaviour:

fun main() = auroraApplication {
    val windowState = rememberWindowState()
    AuroraWindow(
        skin = marinerSkin(),
        state = windowState,
        onCloseRequest = ::exitApplication,
        menuCommands = CommandGroup(
            commands = listOf(
                Command(
                    text = "Fullscreen Top",
                    secondaryContentModel = CommandMenuContentModel(
                        CommandGroup(
                            commands = listOf(
                                Command(
                                    text = "Fullscreen",
                                    action = {
                                        if (windowState.placement == WindowPlacement.Floating) {
                                            windowState.placement = WindowPlacement.Fullscreen
                                        } else {
                                            windowState.placement = WindowPlacement.Floating
                                        }
                                    }
                                )
                            )
                        )
                    )
                )
            )
        )
    ) {

    }
}

https://user-images.githubusercontent.com/74878137/169148532-825f8d99-5371-4fb1-8dc5-d9f34695b33c.mp4

Platform Info

Aurora Version: Tested on both 1.1.0 and 1.2-SNAPSHOT (1.2-20220513.221833-4)

[kirill-grouchnikov]

This is where you can put a breakpoint. Menu buttons are command buttons, and this is where Aurora calls the action block.

This is where Compose Desktop tracks the placement as mutable state, so the updates to the underlying state probably happen on the next frame. Which is why there’s nothing from Compose or Aurora in there.

If I can reproduce this on my Windows 10 machine, I’ll start removing Aurora pieces to see if this is Aurora specific or not.

[igordmn]

the code treats this as a signal that the main window should exit its fullscreen mode

I am starting to understand. If we have two windows, the second window changes the global variable responsible for the current fullscreen window