question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

2.0.0 breaking changes?

See original GitHub issue

@kirill-konshin this is a great library but we’re having issues upgrading to 2.0.0-beta.4 from 1.3.5. We are using Next 6.0.0. Can you kindly add documentation on the breaking changes?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:1
  • Comments:12 (6 by maintainers)

github_iconTop GitHub Comments

3reactions
DonovanCharpincommented, May 3, 2018

Hi @hrdymchl, I just did the migration from next 4.X -> next 6.0.0 and the next-redux-wrapper migration from 1.3.5 to 2.0.0-beta.4.

I think the main thing I had to do was to migrate my main Wrapper (hoc) to the _app.js, after that my code was cleaner and I started the migration.

  • Move withRedux to the _app.js
  • Use connect from react-redux for all my pages
  • Use props.router instead of props.url because of nextjs this time

I just checked my commit and this is the only thing I changed. Check the readme, it gives also some code to reuse when doing the _app.js migration to integrate with the next-redux-wrapper.

I have still one thing I don’t know how to fix. The props from mapStateToProps are not sent to MyApp so maybe there is a breaking change with this. I don’t find in the doc where I can pass this :

//_app.js

const mapStateToProps = state => {
  return {
    translations: state.translations.entities,
    config: state.config.entities,
    theme: state.theme.entities
  };
};

export default withRedux(initStore, mapStateToProps)(MyApp);
0reactions
kirill-konshincommented, Aug 31, 2018

I bet the problem is here: https://gist.github.com/simplynutty/c2daeb74acef6fdfe672c80d65d85c74#file-withgraphql-js-L40 bc this place is not wrapped with Provider.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Semantic Versioning 2.0.0 | Semantic Versioning
What do I do if I accidentally release a backwards incompatible change as a minor version? As soon as you realize that you've...
Read more >
[Documentation] Breaking changes in 2.0 · Issue #2480 - GitHub
This is a meta issue which lists down all breaking changes in OpenSearch 2.0 Inclusive Naming #1549 - Breaking changes in master REST...
Read more >
Migration guide for Az 2.0.0 - Microsoft Learn
This migration guide contains a list of breaking changes made to Azure PowerShell in the Az version 2.0 release.
Read more >
Breaking changes - OpenSearch documentation
OpenSearch documentation; Breaking changes. 2.0.0. Remove mapping types parameter. The type parameter has been removed from all OpenSearch API endpoints.
Read more >
What is the breaking change in semver 2.0.0 - Stack Overflow
I asked on the semver github repo. There are two changes that are not backwards compatible: leading zeros are not accepted; minor version ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found