Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

TypeScript NextPageContext augmentation

See original GitHub issue

Hi everyone,

I am wondering if there is a reason why next-redux-wrapper declares its own NextJSPageContext and NextJSAppContext instead of merging the context props store and isServer into the NextPageContext interface?

Background: I am having problems setting up my _app component with TypeScript because the App class from “next/app” can only be extended when getInitialProps takes an AppContext as its parameter. Augmenting NextPageContext would be a nice solution in my opinion. Also, store and isServer would be available on every NextPage’s getInitialProps context without any extra configuration.

If this approach is welcome I would be happy to create a PR! In this case, I would augment NextPageContext and deprecate NextJSPageContext and NextJSAppContext.

Issue Analytics

State:
Created 4 years ago
Reactions:6
Comments:11 (8 by maintainers)

Top GitHub Comments

3reactions

kirill-konshincommented, Feb 11, 2020

https://github.com/kirill-konshin/next-redux-wrapper/pull/176 code is in master now, it will be released after I do some more testing. Hopefully this week.

3reactions

kirill-konshincommented, Dec 5, 2019

Pull request is welcome.