Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Binlog Viewer Not Displaying Warnings

See original GitHub issue

Context

We recently added a feature in MSBuild called Change Waves. The basic idea behind the feature is to set MSBuildDisableFeaturesFromVersion to some MSBuild version, and that would disable a set of features behind that version (and all future versions). The current versions are 16.8, 16.10, and 17.0. The issue starts here: If a user sets MSBuildDisableFeaturesFromVersion to several types of invalid versions (like a garbage value) it throws a warning. Here is the source for where this warning is thrown.

The problem is that this warning is shown in the output of a build (VS and cmd line), but it doesn’t show up in the viewer. If you replay the binlog with diagnostic logging, you can see the warning in the generated msbuild.log

@rainersigwald and I have observed that it gets picked up in the viewer’s WarningRaised function, but isn’t drawn for some reason.

See attached binlog. msbuild.zip

Issue Analytics

State:
Created 3 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

KirillOsenkovcommented, Sep 29, 2020

Code review please: https://github.com/KirillOsenkov/MSBuildStructuredLog/commit/61cd163a9c369d7184bad31a9230794b0c8d66b4

0reactions

benvillaloboscommented, Sep 29, 2020

LGTM, thanks for the quick fix!

Top Results From Across the Web

4.6.9 mysqlbinlog — Utility for Processing Binary Log Files

With this option, if mysqlbinlog reads a binary log event that it does not recognize, it prints a warning, ignores the event, and...

MSBuild Log Viewer

Security Warning. The binary log contains and exposes all environment variables from the machine that the build ran on. If your environment variables...

Partial mysqlbinlog on latest binlog file

Warning: this binlog is either in use or was not closed properly. How do I force MySQL to start logging in the next...

Binary log error in mysql

When I am trying to check binary log: SHOW BINARY LOGS;. I get this error: ERROR 1381 (HY000): You are not using binary ......

SHOW WARNINGS - MariaDB Knowledge Base

SHOW WARNINGS shows the error, warning, and note messages that resulted from the last statement that generated messages in the current session.