Can't add multiple headers with the same name (cookies)

The code:

val (request, response, result) = reqUrl.httpGet()
                        .header(Pair("Cookie", "val1=x"),
                                Pair("Cookie","val2=y"),
                                Pair("Cookie","val3=z"))
                        .responseString()

Expected functionality:

All cookies are included in request

Actual functionality:

Only the last Pair with val3 is included in the request

This happens because, in Request.kt line 28, the headers variable is a MutableMap, instead of perhaps an ArrayList of Pairs or a similar datatype.

Multiple headers with the same name is allowed in the HTTP spec, section 4.2

[markGilchrist]

@SleeplessByte do you have any thoughts on the comment above? I think producing

Cookie: val1=x
Cookie: val2=y
Cookie: val3=z

is almost impossible, however

cookie: a=b; c=d; e=f

is what my current pr hope to achieve.

@Fibonacci- your feedback would be warmly welcome!

[SleeplessByte]

AAs per the spec, you should add the space: i.e. this would be Cookie: val1=x; val2=y; val3=z. Note that I used a semi-colon, which is the correct delimiter. Here is the RFC spec:

https://tools.ietf.org/html/rfc7540#section-8.1.2.5

8.1.2.5.  Compressing the Cookie Header Field

   The Cookie header field [COOKIE] uses a semi-colon (";") to delimit
   cookie-pairs (or "crumbs").  This header field doesn't follow the
   list construction rules in HTTP (see [RFC7230], Section 3.2.2), which
   prevents cookie-pairs from being separated into different name-value
   pairs.  This can significantly reduce compression efficiency as
   individual cookie-pairs are updated.

   To allow for better compression efficiency, the Cookie header field
   MAY be split into separate header fields, each with one or more
   cookie-pairs.  If there are multiple Cookie header fields after
   decompression, these MUST be concatenated into a single octet string
   using the two-octet delimiter of 0x3B, 0x20 (the ASCII string "; ")
   before being passed into a non-HTTP/2 context, such as an HTTP/1.1
   connection, or a generic HTTP server application.

   Therefore, the following two lists of Cookie header fields are
   semantically equivalent.

     cookie: a=b; c=d; e=f

     cookie: a=b
     cookie: c=d
     cookie: e=f

However from experience I know that this format:

Cookie: val1=x
Cookie: val2=y
Cookie: val3=z

is not accepted by ALL nodes out there (especially older software/nodes will simply drop all but the first or drop all but the last).