validatorResponseInterceptor always response FuelError

Fuel: v1.12.0

I add validatorResponseInterceptor(200..499) to FuelManager Should it allow 200 to 499 as valid status code?

I checked FuelManager that it add validatorResponseInterceptor as new interceptor, but it already has validatorResponseInterceptor(200..299). So it might do the 200..299 before my interceptor and response error.

Here is my code

with(FuelManager.instance) {
    basePath = BuildConfig.BASE_URL

    addResponseInterceptor(validatorResponseInterceptor(200..499))
}

"xxx".httpPost()
    .responseObject(...) { _, _, result ->
        // status code is 422
        result.fold({ items ->
             // Should it response here?
        }, { error ->
             // Always get error         
        })
    }

[kittinunf]

You are right, true … I think we should do that. Sound like a good item for another PR.

I think we could improve in this block.

https://github.com/kittinunf/Fuel/blob/0001c44efe9bf1389ba742292a45b62837723801/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/Deserializable.kt#L69-L73

But, going down this route, we require passing in an Error type and we probably need to upgrade our class to FuelError<T> to accommodate this.

Call-site could be ugly.

Before

fun <T : Any> responseObject(deserializer: ResponseDeserializable<T>, handler: (Request, Response, Result<T, FuelError>) -> Unit) = response(deserializer, handler)

After

fun <V : Any, E: Any> responseObject(deserializerV: ResponseDeserializable<V>, deserializerE: ResponseDeserializable<E>, handler: (Request, Response, Result<V, FuelError<E>>) -> Unit) 

Then, it looks 😢 😭

Another idea is to make the deserializable of error object become a bit more like “on-demand”

"xxx".httpPost()
    .responseObject(...) { _, _, result ->
        // status code is 422
        result.fold({ items ->
             
        }, { error ->
             val errorObject = error.deserialize(deseriaizer)
             //then use your errorObject 
        })
    }

So, we add a ability to deserialize into the FuelError class.

[kittinunf]

Yeah. I think I could find some time this weekend to tackle this