Invalid static method resolution

I have a class hierarchy, where class Child extends class Parent, and they both define a method “newInstance”:

class Parent {
  static
  public Parent newInstance(){
    return new Parent();
  }
}

class Child extends Parent {
  static
  public Child newInstance(){
    return new Child();
  }
}

I’m trying to obtain a new Child instance by invoking the static method Child#newInstance(). However, I keep getting Parent instances (instead of Child instances), which indicates that PyJNIus has “redirected” my static method invocation to Parent#newInstance(). This is obviously incorrect behaviour.

Using PyJNIus version 1.2.0.

[tshirtman]

From what i gather (didn’t look at this code in some time), we use Class.getMethods() to populate our list of methods, https://docs.oracle.com/javase/7/docs/api/java/lang/Class.html#getMethods() and if we have multiple signatures for the same name, we use JavaMultipleMethod, and use compute_score at runtime to determine which method to call depending on various parameters, but… https://github.com/kivy/pyjnius/blob/5f6aa738b2b7ae496ec43bfadbf9933ee640bb7b/jnius/jnius_utils.pxi#L340-L352

i think this should try to give less points the further in the class hierarchy of classes the method come from, because the previously mentioned getMethods method makes no promise on the order of the returned list, we might currently return any implementation, not necessarily the one the programmer expect.

[tshirtman]

Thank you for confirmation, i’ll try adding the test case later, so we can avoid regressions 😃, then merge.