Aircon current temperature validation should be removed in onTemperature method
See original GitHub issueWhen I set my aircon configuration with min and max values:
“minTemperature”: 18, “maxTemperature”: 30,
I get some weird behaviour, those restrictions apply also to the “sensor temperature” and for me that does not make sense. I was expecting 18-30 min and max values to be the operation values my heater/cooler supports.
Eg. min temperature operation value I can set for my heat pump is 18 and room temperature is 15, then I get the following warning: [Broadlink RM] [INFO] Reported temperature (15.11) is too low, setting to minTemperature (18).
My suggestion would be to remove those checks in the “onTemperature” method:
if (temperature > config.maxTemperature) {
log(\x1b[36m[INFO]\x1b[0m Reported temperature (${temperature}) is too high, setting to \x1b[33mmaxTemperature\x1b[0m (${maxTemperature}).
)
temperature = config.maxTemperature
}
if (temperature < config.minTemperature) {
log(\x1b[36m[INFO]\x1b[0m Reported temperature (${temperature}) is too low, setting to \x1b[33mminTemperature\x1b[0m (${minTemperature}).
)
temperature = config.minTemperature
}
Issue Analytics
- State:
- Created 3 years ago
- Comments:9 (3 by maintainers)
Top GitHub Comments
I think you’re right. Missed those ones sorry.
New beta shortly. Thanks!
The latest Beta has this fixed. Let me know if you have any issues.