Multiple method calls during property updates.

Problem:

invalidateViewHolders(), updateApapterMonthConfig() and updateAdapterViewConfig() methods are called multiple times if related properties are set in the CalendarView class.

Proposed solution:

Add an update method which will not trigger any of the above methods if properties are updated inside it. This way we avoid creating setter methods for all related properties of CalendarView.

Something like this:

open class CalendarView : RecyclerView {
	....
    private var isUpdating = false
    private var pendingAdapterMonthConfigUpdate = false
    private var pendingAdapterViewConfigUpdate = false
    private var pendingViewHolderInvalidation = false
    fun update(block: CalendarView.() -> Unit) {
        isUpdating = true
        this.block()
        isUpdating = false
        if (pendingAdapterMonthConfigUpdate) updateAdapterMonthConfig()
        if (pendingAdapterViewConfigUpdate) updateAdapterViewConfig()
        if (pendingViewHolderInvalidation) invalidateViewHolders()
		pendingAdapterMonthConfigUpdate = false
        pendingAdapterViewConfigUpdate = false
        pendingViewHolderInvalidation = false
    }
	....
}

Then the update methods will look like:

private fun updateAdapterMonthConfig() {
    if (isUpdating) {
        pendingAdapterMonthConfigUpdate = true
        return
    }
    ....
}

private fun invalidateViewHolders() {
    if (isUpdating) {
        pendingViewHolderInvalidation = true
        return
    }
    ....
}

private fun updateAdapterViewConfig() {
    if (isUpdating) {
        pendingAdapterViewConfigUpdate = true
        return
    }
    ....
}

Now using example 1 where we update a lot of configs, we can write:

animator.doOnStart {
    if (!monthToWeek) {
        binding.exOneCalendar.update { // No more => exOneCalendar.apply{}
            inDateStyle = InDateStyle.ALL_MONTHS
            maxRowCount = 6
            hasBoundaries = true
        }
    }
}

Continued from #184

[luis-cortes]

The first one is what I had in mind. However, I think maybe we should start with some of the props that have more obvious groupings like padding, margin, and height/width.

Even doing just those would be a big win I think.

[kizitonwose]

Okay, so I want to start with grouping the methods that directly cause a creating of MonthConfig since I want to allow generating the dates in the background.

This is what it looks like presently:

fun updateMonthConfiguration(
    inDateStyle: InDateStyle = this.inDateStyle,
    outDateStyle: OutDateStyle = this.outDateStyle,
    maxRowCount: Int = this.maxRowCount,
    hasBoundaries: Boolean = this.hasBoundaries
) {

}

Does the method look like what you had in mind? Or were you thinking more in the direction of something like:

fun updateMonthConfiguration(config: MonthConfig) {

}