Becoming a real "community" repo
See original GitHub issueThis is just to discuss the possibility of adding a few direct contributors to the repo besides myself. I’m still poking a few other people, but ideally I’m hoping for 4 collaborators including myself.
The things I’m looking for help with:
- Responding to issues and PRs.
- If you have any specific areas or platform of expertise, e.g. jetbrains/vim or Mac/Linux, take some degree of “ownership” of those bits where feasible.
Collaborator guidelines
-
Take care of yourself and your health/needs first. Limit your time commitment to this effort.
-
For “minor” fixes/improvements/bugs/new apps, you’re free to contribute without any review
-
For significant new development/refactoring you feel makes sense, it’s likely still prudent to get a review from one of the other collaborators, or open a discussion as appropriate before committing your time?
Potential guidelines for contributions (PR review, etc)
-
Any addition to the global grammar should be scrutinized a bit more thoroughly. The more specific a new context, the less scrutiny I typically apply.
-
New grammars should follow the [subject][verb] standard where-ever possible.
-
For Mac OS X, the bundle id should be used for defining app contexts, rather than the name.
-
For Windows, both the friendly app name and exe name should be used for defining app contexts. For some people, the MUICache breaks.
-
For new web apps, ensure the domain is used to minimize potential mismatches https://github.com/knausj85/knausj_talon/blob/master/apps/web/window_titles.md
-
New applications should support the appropriate ‘generic’ grammars where possible
generic_browser.talon
find_and_replace.talon
line_commands.talon
multiple_cursors.talon
snippets.talon
splits.talon
tabs.talon
- New programming languages should support the appropriate ‘generic’ grammars where possible as well
operators.talon
programming.talon
comment.talon
block_comment.talon
and should support the lists
user.code_functions
user.code_libraries
where appropriate. See e.g. csharp.py/csharp.talon. At least, until we come up with something better 👍
Issue Analytics
- State:
- Created 3 years ago
- Comments:10 (5 by maintainers)
Top GitHub Comments
Figured I’d check-in to see how’s it going. Any complaints or issues?
Seems to be working well, as far I can see.
I’m in