afterCreate in Pool with better-sqlite3

Environment

Knex version: 1.0.1

Bug

1. After switching from sqlite3 to better-sqlite3 we are having issues with the following line of code:

knexConfig.pool = { afterCreate: (conn, cb) => conn.run("PRAGMA foreign_keys = ON", cb), };

1. Error: TypeError: conn.run is not a function at afterCreate (src/shared/database/configurations/KnexConfigFactory.ts:9:128) at node:internal/util:360:7 at new Promise (<anonymous>) at afterCreate (node:internal/util:346:12) at create (node_modules/knex/lib/client.js:252:50)

Question

Is this a known bug or is there another way to use foreign keys with better-sqlite3?

[benjdlambert]

Yep - will try and take a look before the weekend!

[lvivier]

better-sqlite3’sDatabase class doesn’t have a run() method, but it does have an exec() method. There’s also a pragma() method specifically for executing PRAGMA statements. From the docs:

It’s better to use this method instead of normal prepared statements when executing PRAGMA, because this method normalizes some odd behavior that may otherwise be experienced.

You can probably do something like (not tested):

(conn, cb) => {
  conn.pragma("foreign_keys = ON")
  cb()
}