Database connection is not correctly destroyed after knex 0.12.2

Hey 👋

I have recently updated knex from 0.12.2 to 0.12.7 and noticed that the database connection is not closed when calling connection.destroy. The result is, that a process doesn’t exit.

Here is a snippet:

....
this.connection = knex(...);

return this.connection.transaction(function(txn) {
   return doSomething(txn)
       .finally(function() {
           return self.connection.destroy()
                .then(function () {
                    debug('Destroyed connection');
                });
       });
})

NOTE: debug(‘Destroyed connection’) get’s called.

I have tested all knex versions and it starts in 0.12.3.

The code works for me with 0.12.2, but does not with 0.12.3. Is there anything i can change in my code to get it working with > 0.12.2?

Otherwise, I went through the changes, maybe related to the pool update https://github.com/tgriesser/knex/pull/1702?

Thank you so much! Kate

[wubzz]

Based on the changelog I would guess #1731 causes this in some way. Some changes to acquireConnection was done so that connections are properly returned to the pool.

Edit: Testing with postgres, I’m unable to reproduce the issue as described, while switching between versions 0.12.2 -> 0.12.7. Viewing the PG server status, the connections appear to close properly and returns to the pool in both versions. The process does not exit in either version.

const db = require('knex')({...});

db
.transaction((tr) => tr('user').select())
.then(() => db.destroy())
.then(() => console.log('Destroyed'));
//No open connections in server status

[wubzz]

@kirrg001 I see, I thought your app remained idle eventhough all attempts of acquiring connections were successful, but I understand now that’s not the case.

I’ll merge this in right now, definitely a bug. Thanks for the report!