Does rollback really work?

Knex version: 0.16.3 Database + version: mysql, 5.5 OS: Windows

I am making the inner query fail by adding a wrong column! Inner query fails, but does not rollback whole transaction! Here is my code:

return knex.transaction(function (trx) {
	return trx.insert({...}, 'id').into('dept').then(function (response) { **// passes, but should rollback!**
		return trx.batchInsert('emp', [{...}, {...}], 10); **// wrong query!**
	}).then(function (value) {
		console.log('Inside success:', value);
		// trx.commit();
	}).catch(function (error) {
		console.log('Inside error:', error); **// comes here!**
		// trx.rollback(error);
		throw new Error('Rolling back!');
	});
}).catch((err) => {
	console.log("We get here", err); **// comes here!; still no rollback??**
});

I tried with trx.rollback(); trx.rollback(error) or even throwing Error; with promise return and without promise return. It falls in both error blocks (inner and outer); still surprisingly no rollback!!

[tariq-tb]

I ran into transaction issues with knex and a legacy MySQL db, which led me to this thread. Cause of the issue was MyISAM was being used instead of InnoDB, so ensure you’re using the latter.

[elhigu]

Cannot reproduce, add complete reproduction code please… something that creates necessary tables and shows that the code above does not work. Check CONTRIBUTING.md why and what minimal reproduction code means.