`first()` turns an `update` query into a `select`

> knex('pool_enterprise.test').update({'state': 'awesome'}).first().toSQL()
{ method: 'first',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 1 ],
  __knexQueryUid: '3698eb45-5165-46af-aa43-9376e048cb27',
  sql: 'select * from "pool_enterprise"."test" limit ?' }

Probably should just throw an error? I mean you can do an UPDATE RETURNING but I don’t seen LIMIT clause allowed in the postgres docs

Tested on postgres.

How it happened is I had a limit supposed to be on a subquery but I got the parens wrong. Was a bit hard to debug.

Knex version:

knex@^0.12.9:
  version "0.12.9"
  resolved "https://registry.yarnpkg.com/knex/-/knex-0.12.9.tgz#aa852138c09ed46181e890fd698270bbe7761124"

[elhigu]

Thanks for the report. Throwing error sounds good.

Also probably knex should throw an error in every case where calling new builder method changes some update -> plain select.

[wubzz]

With .returning not being supported by all dialects it might not be good to give .first() two different meanings between dialects.

I would opt for just throwing an error that update was changed to select.