Foreign Key onDelete not a function

Trying on add onDelete('CASCADE') to a parent_id foreign key. I’ve dropped the column with t.dropColumn('parent_id'), and now I’m trying to add the onDelete part. But t.foreign('parent_id').references('id').onDelete('CASCADE') doesn’t work because t.foreign(…).references(…).onDelete is not a function

How can I get this to work? Why can’t I chain onDelete to this foreign key creation?

[rbadillap]

@elhigu please correct me if I’m wrong, for me this is not a bug due this example is not indicating the table to be related.

On this piece of code:

t.foreign('parent_id').references('id').onDelete('CASCADE');

parent_id is the foreign key (assuming that it was defined before), but which is the table related?

There’s 3 ways to reference a table in a foreign key definition:

1. Within references

t.foreign('parent_id').references('tableName.id').onDelete('CASCADE');

1. Using on

t.foreign('parent_id').references('id').on('tableName').onDelete('CASCADE');

1. Using inTable (which is an alias of on)

t.foreign('parent_id').references('id').inTable('tableName').onDelete('CASCADE');

These 3 ways works perfectly with no issues.

Thirdly and finally, take a look at https://github.com/tgriesser/knex/blob/master/src/schema/tablebuilder.js#L202 there’s a condition to check if references contains a dot (.), if don’t, there’s no return, that’s why you’re getting the error: onDelete is not a function

[elhigu]

@rbadillap Looks like you are right that those work fine, however better error message would be nice. I’m really surprised that .references('tableName.id') and .references('id') returned different builder as a result (+ funnily it works in other order when cascade is given first and references last).