Limit is not converted to integer

I have this function:

exports.lastCovers = function(page, pageSize) {
  console.log(typeof pageSize)
  console.log(typeof page)
  return Cover.collection().query(function(qb) {
    qb.orderBy('registration_date', 'desc').limit(pageSize).offset((page - 1) * pageSize);
  }).fetch();
}

It prints:

string
string

And happens this error:

{ __cid: '__cid8',
  method: 'select',
  options: undefined,
  bindings: [ '20', 0 ],
  sql: 'select `cover`.* from `cover` order by `registration_date` desc limit ? offset ?' }
{ [Error: ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''20' offset 0' at line 1]
  code: 'ER_PARSE_ERROR',
  errno: 1064,
  sqlState: '42000',
  index: 0 }

The offset is converted to integer but limit is not.

[VincentVazzo]

In Postgres, at least, one can do “LIMIT ALL” in a query. It would be nice to be able to send in “ALL” (or an equivalent) into limit() and have it not emote a warning everytime.

[rhys-vdw]

@VincentVazzo Please open a new issue with this feature request. This issue is closed.