Memory leak in knex v0.13.0

Hi,

When importing, then destroying, then reset modules a lot of times with jest, I have some warning about memory leak MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 SIGABRT listeners added. Use emitter.setMaxListeners() to increase limit

I think that destroy() leave listener that should be removed.

Here is the (useless) code to reproduce the issue :

//@flow

import k from 'knex';
import path from 'path';

const config = {
  client: 'sqlite3',
  connection: {
    filename: path.join(__dirname, './database.sqlite'),
  },
  pool: {
    min: 1,
    max: 1,
  },
  migrations: {
    tableName: 'knex_migrations',
  },
  useNullAsDefault: true,
  timezone: 'UTC',
};

let knex;

describe('pppppppppp', () => {
  beforeEach(async () => {
    jest.resetModules();
    knex = k(config);
  });

  afterEach(async () => {
    await knex.destroy();
  });

  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
  test('test', () => {});
});

the output :

Is it a bad use or a bug ? Thanks in advance.

[badwulfy]

@fl0w nop, it does not fix the issue

[wubzz]

From my previous tests this should be fixed by #2208, so closing this for now. If it’s still an issue in upcoming 0.14, feel free to reopen.